Uploaded image for project: 'Fabric'
  1. Fabric
  2. FAB-17672

Prevent gossip probes from registering as long lasting connections

    XMLWordPrintable

Details

    • Story
    • Status: Closed
    • Medium
    • Resolution: Done
    • None
    • v2.1.0
    • fabric-gossip
    • None
    • Unset
    • Unset
    • Unset

    Description

      Gossip bootstrap peer and anchor peer connection establishments are a two step process:

      1. Connect to the remote endpoint, and figure out its organization association
      2. Connect to the remote endpoint once again, this time sending membership information according to what it is eligible to.

      Unfortunately, if the responding peer connects to the initiator peer at the same time, the connection of (1) will be overwritten by the connection (gossip keeps a single connection among every pair of peers) from the responder peer and the initiator peer will consider the responder peer as dead.

      In production, where peers run for a long time and constnatly retry, this is not a problem.

      However, in integration tests that expect data to be disseminated in a timely manner, this might cause flakes.

       

      This story proposes to mark probes (1) with a special boolean flag that indicates this connection is not a long lasting one, and thus there is no point to add it to the connection store.

      Attachments

        Activity

          People

            yacovm Yacov Manevich
            yacovm Yacov Manevich
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: