Uploaded image for project: 'Indy Node'
  1. Indy Node
  2. INDY-1564

Discard any client requests during view change

    Details

    • Type: Task
    • Status: Complete
    • Priority: Medium
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: 1.6.73
    • Component/s: None
    • Labels:
      None

      Description

      As of now, we don't process any client requests during view change (just not take them from the client's ZMQ queue while view change is in progress).

      That may potentially lead to memory leaks. Most probably the client will get timeout for the request received during the view change, so it should not be a big issue to discard it.

      Acceptance criteria:

      • Process client queue during the view change (`serviceClientMsgs` in node.py), but discard all requests (send NACK) with a message "Discarding client request since View Change is in progress".
      • Write tests

        Attachments

          Activity

            People

            • Assignee:
              zhigunenko.dsr NIkita Zhigunenko
              Reporter:
              ashcherbakov Alexander Shcherbakov
              Watchers:
              Alexander Shcherbakov, NIkita Zhigunenko, Renata Toktar
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: