Uploaded image for project: 'Indy Node'
  1. Indy Node
  2. INDY-1643

Monitor needs to take into account requests not passing dynamic validation when trigerring view change

    Details

    • Type: Task
    • Status: Complete
    • Priority: High
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: 1.6.73
    • Component/s: None
    • Labels:
      None
    • Sprint:
      EV 18.17 Service Pack, EV 18.18 Service Pack 2
    • Documentation Impact:
      Unset

      Description

      When Monitor calculates throughput and latency for master, it takes into account only valid requests, that is requests passing dynamic validation. But non-master instances don't have dynamic validation, so all requests are taken into account there.

      It may lead to false-positive View Changes since backup instances will think that master degraded, while it just had a lot of invalid requests.

      Acceptance criteria:

      • Include information about all requests into Ordered message
      • Pass all requests into Monitor
      • Take only valid requests when processing Ordered message on Node.

      Can be done together with INDY-1642 to take into account a new PrePrepare format.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                ozheregelya Olga Zheregelya
                Reporter:
                ashcherbakov Alexander Shcherbakov
                Watchers:
                Alexander Shcherbakov, Andrew Nikitin, Olga Zheregelya
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: