Uploaded image for project: 'Indy Node'
  1. Indy Node
  2. INDY-1926

Replica's primaryName is not checked for None during logging

    Details

    • Type: Bug
    • Status: Complete
    • Priority: Highest
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Documentation Impact:
      Unset
    • Sprint:
      Ev 18.25

      Description

      It is a normal situation if replica's primaryName is None (for example, during the view change process). But there is a place where it is not checked during logging.

      Back trace:

      Dec 19 02:20:53 irelandQALive3.qatest.evernym.com env[2638]: File "/usr/local/lib/python3.5/dist-packages/plenum/server/has_action_queue.py", line 110, in wrapper
      Dec 19 02:20:53 irelandQALive3.qatest.evernym.com env[2638]: action()
      Dec 19 02:20:53 irelandQALive3.qatest.evernym.com env[2638]: File "/usr/local/lib/python3.5/dist-packages/plenum/server/monitor.py", line 418, in check_unordered
      Dec 19 02:20:53 irelandQALive3.qatest.evernym.com env[2638]: handler(new_unordereds)
      Dec 19 02:20:53 irelandQALive3.qatest.evernym.com env[2638]: File "/usr/local/lib/python3.5/dist-packages/plenum/server/replicas.py", line 227, in unordered_reques
      t_handler_logging
      Dec 19 02:20:53 irelandQALive3.qatest.evernym.com env[2638]: .format(reqId, duration, replica.primaryName.split(':')[0], prepre_sender,
      Dec 19 02:20:53 irelandQALive3.qatest.evernym.com env[2638]: AttributeError: 'NoneType' object has no attribute 'split'

        Attachments

          Activity

            People

            • Assignee:
              sergey-shilov Sergey Shilov
              Reporter:
              sergey-shilov Sergey Shilov
              Watchers:
              Sergey Shilov
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: